Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): handle errors thrown when importing html renderer (#32417) #32423

Merged
merged 1 commit into from
Jul 19, 2021
Merged

fix(gatsby): handle errors thrown when importing html renderer (#32417) #32423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions packages/gatsby/src/commands/build-html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,13 +330,6 @@ export const doBuildPages = async (
try {
await renderHTMLQueue(workerPool, activity, rendererPath, pagePaths, stage)
} catch (error) {
const pageData = await getPageData(error.context.path)
const truncatedPageData = truncateObjStrings(pageData)

const pageDataMessage = `Page data from page-data.json for the failed page "${
error.context.path
}": ${JSON.stringify(truncatedPageData, null, 2)}`

const prettyError = await createErrorFromString(
error.stack,
`${rendererPath}.map`
Expand All @@ -345,7 +338,17 @@ export const doBuildPages = async (
const buildError = new BuildHTMLError(prettyError)
buildError.context = error.context

reporter.error(pageDataMessage)
if (error?.context?.path) {
const pageData = await getPageData(error.context.path)
const truncatedPageData = truncateObjStrings(pageData)

const pageDataMessage = `Page data from page-data.json for the failed page "${
error.context.path
}": ${JSON.stringify(truncatedPageData, null, 2)}`

reporter.error(pageDataMessage)
}

throw buildError
}
}
Expand Down