Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tutorial): improve a11y of layout component #32539

Merged
merged 2 commits into from
Jul 29, 2021
Merged

docs(tutorial): improve a11y of layout component #32539

merged 2 commits into from
Jul 29, 2021

Conversation

meganesu
Copy link
Contributor

Description

Updates the semantic HTML in the Layout component.

  • Only wrap page-specific elements in the <main> element.
  • Use <header> element for page title in Part 4.

Documentation

  • /docs/tutorial/part-2
  • /docs/tutorial/part-4

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 29, 2021
@meganesu meganesu added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 29, 2021
bradledford
bradledford reviewed Jul 29, 2021
View reviewed changes
Copy link

@bradledford bradledford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update!

jxnblk
jxnblk approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@jxnblk jxnblk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@meganesu meganesu merged commit cfce9eb into master Jul 29, 2021
@meganesu meganesu deleted the tutorial/layout-component-a11y branch July 29, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradledford bradledford bradledford left review comments

@jxnblk jxnblk jxnblk approved these changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meganesu @bradledford @jxnblk