fix(gatsby-source-drupal): check relationships type exists on node before filtering #33181

KyleAMathews · 2021-09-14T17:58:19Z

Fix issue found on customer site.

Annoyingly I wasn't able to create a reproduction for this so we'll have to file this under "Race Conditions: Generic, Cause Unknown".

…fore filtering

KyleAMathews · 2021-09-14T18:59:27Z

packages/gatsby-source-drupal/src/utils.js

@@ -4,7 +4,6 @@ const {
  nodeFromData,
  downloadFile,
  isFileNode,
-  getHref,


this wasn't being used

DSchau

Test would always be nice, but this seems to resolve a null/undefined data issue 👍

packages/gatsby-source-drupal/src/utils.js

KyleAMathews · 2021-09-14T22:23:07Z

I tried for an hour to write a test until I finally gave up 😅

Co-authored-by: Dustin Schau <[email protected]>

…fore filtering (#33181) * fix(gatsby-source-drupal): check relationships type exists on node before filtering * Update packages/gatsby-source-drupal/src/utils.js Co-authored-by: Dustin Schau <[email protected]> * format Co-authored-by: Dustin Schau <[email protected]>

…fore filtering (#33181) * fix(gatsby-source-drupal): check relationships type exists on node before filtering * Update packages/gatsby-source-drupal/src/utils.js Co-authored-by: Dustin Schau <[email protected]> * format Co-authored-by: Dustin Schau <[email protected]> (cherry picked from commit d4f8355)

…fore filtering (#33181) (#33228) * fix(gatsby-source-drupal): check relationships type exists on node before filtering * Update packages/gatsby-source-drupal/src/utils.js Co-authored-by: Dustin Schau <[email protected]> * format Co-authored-by: Dustin Schau <[email protected]> (cherry picked from commit d4f8355) Co-authored-by: Kyle Mathews <[email protected]>

fix(gatsby-source-drupal): check relationships type exists on node be…

ed925aa

…fore filtering

gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 14, 2021

Merge remote-tracking branch 'origin/master' into nuder-drupal-fix

6d93849

KyleAMathews added topic: source-drupal Related to Gatsby's integration with Drupal type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 14, 2021

KyleAMathews commented Sep 14, 2021

View reviewed changes

DSchau previously approved these changes Sep 14, 2021

View reviewed changes

DSchau reviewed Sep 14, 2021

View reviewed changes

packages/gatsby-source-drupal/src/utils.js Outdated Show resolved Hide resolved

Update packages/gatsby-source-drupal/src/utils.js

6e5d0dd

Co-authored-by: Dustin Schau <[email protected]>

KyleAMathews dismissed DSchau’s stale review via 6e5d0dd September 14, 2021 22:23

format

53ee03e

KyleAMathews merged commit d4f8355 into master Sep 14, 2021

KyleAMathews deleted the nuder-drupal-fix branch September 14, 2021 22:53

gatsbybot mentioned this pull request Sep 17, 2021

fix(gatsby-source-drupal): check relationships type exists on node before filtering (#33181) #33228

Merged

This was referenced Jun 19, 2022

[Snyk] Security upgrade gatsby from 2.32.13 to 3.14.0 0xSebin/gatsby#609

Open

[Snyk] Security upgrade gatsby from 2.32.13 to 3.14.0 nidhi42/gatsby#1022

Open

[Snyk] Fix for 1 vulnerabilities Xtuden-com/gatsby#2126

Open

0xSebin mentioned this pull request Jan 31, 2023

[Snyk] Security upgrade gatsby from 2.32.13 to 3.14.0 0xSebin/gatsby#2015

Open

kaocher82 mentioned this pull request Feb 1, 2023

[Snyk] Security upgrade gatsby from 2.32.13 to 3.14.0 Xtuden-com/gatsby#3551

Open

0xSebin mentioned this pull request Feb 1, 2023

[Snyk] Security upgrade gatsby from 2.32.13 to 3.14.0 0xSebin/gatsby#2016

Open

snyk-bot mentioned this pull request Mar 3, 2023

[Snyk] Fix for 4 vulnerabilities Xtuden-com/gatsby#3557

Open

snyk-bot mentioned this pull request Mar 16, 2023

[Snyk] Fix for 5 vulnerabilities ajesse11x/gatsby#1865

Open

ajesse11x mentioned this pull request Mar 24, 2023

[Snyk] Fix for 2 vulnerabilities ajesse11x/gatsby#1866

Open

snyk-bot mentioned this pull request Apr 19, 2023

[Snyk] Fix for 6 vulnerabilities ajesse11x/gatsby#1878

Open

saurabharch mentioned this pull request Jun 16, 2023

[Snyk] Fix for 6 vulnerabilities saurabharch/gatsby#2172

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(gatsby-source-drupal): check relationships type exists on node before filtering #33181

fix(gatsby-source-drupal): check relationships type exists on node before filtering #33181

KyleAMathews commented Sep 14, 2021

KyleAMathews Sep 14, 2021

DSchau left a comment

KyleAMathews commented Sep 14, 2021

fix(gatsby-source-drupal): check relationships type exists on node before filtering #33181

fix(gatsby-source-drupal): check relationships type exists on node before filtering #33181

Conversation

KyleAMathews commented Sep 14, 2021

KyleAMathews Sep 14, 2021

Choose a reason for hiding this comment

DSchau left a comment

Choose a reason for hiding this comment

KyleAMathews commented Sep 14, 2021