fix(gatsby): fix schema printing for gatsby-transformer-json #35098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: GraphQL
pieh
commented
Mar 10, 2022
| @@ -342,20 +343,13 @@ export const printTypeDefinitions = ({ | |||
| } | |||
|
|
|||
| const internalTypes = [ | |||
| `Boolean`, | |||
| ...builtInScalarTypeNames, | |||
| `Buffer`, | |||
There was a problem hiding this comment.
In this PR I essentially just dropped Json from the list, but we still have some questionable type names here - in particular Buffer is raising my eyebrow. For now leaving it as I don't quite understand the reason for it + it doesn't seem to cause problems (yet)
2 tasks
LekoArts
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adjust our InternalTypes list for schema printing and removes wrong
Jsontype from itRelated Issues
Fixes #34610