Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Remove removeOffCanvasPaths svgo option #35788

Merged
merged 1 commit into from
May 31, 2022

Conversation

just-boris
Copy link
Contributor

@just-boris just-boris commented May 30, 2022

Description

Remove removeOffCanvasPaths optimisation, which has known issues: svg/svgo#1646.

This is not enabled by default in SVGO, so there is more risk, because such optimizations are less widely tested

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 30, 2022
@just-boris
Copy link
Contributor Author

Not sure what the failed test is about. Looks like flakiness, but I can't restart the build

@LekoArts LekoArts changed the title Remove broken SVGO optimization fix(gatsby): Remove removeOffCanvasPaths svgo option May 31, 2022
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 31, 2022
@LekoArts LekoArts merged commit c3a3f68 into gatsbyjs:master May 31, 2022
@just-boris just-boris deleted the patch-1 branch May 31, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants