Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDXv2: remove default layouts and add support for pageQueries #35983

Merged
merged 31 commits into from
Jul 4, 2022
Merged

MDXv2: remove default layouts and add support for pageQueries #35983

merged 31 commits into from
Jul 4, 2022

Conversation

axe312ger
Copy link
Collaborator

The current implementation of the new version does not support pageQueries in template files.

This rewrites the codebase to enable JS page components that load a single MDX in the background which gets injected.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 23, 2022
@axe312ger axe312ger changed the base branch from master to feat/mdx-v2 June 23, 2022 12:43
@LekoArts LekoArts added topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 24, 2022
@axe312ger axe312ger force-pushed the feat/mdx-v2-remove-default-layouts branch from 550aff9 to f38dd2f Compare June 24, 2022 13:02
@axe312ger axe312ger changed the base branch from feat/mdx-v2 to refactor/mdx-v2-add-toc-and-excerpt June 24, 2022 13:02
@axe312ger axe312ger force-pushed the refactor/mdx-v2-add-toc-and-excerpt branch from 2644bb8 to 2c2e156 Compare June 24, 2022 13:04
@axe312ger axe312ger force-pushed the feat/mdx-v2-remove-default-layouts branch from f38dd2f to a3d3b12 Compare June 24, 2022 13:05
@axe312ger axe312ger marked this pull request as ready for review June 24, 2022 13:06
@axe312ger axe312ger requested a review from LekoArts June 24, 2022 13:06
@axe312ger axe312ger self-assigned this Jun 24, 2022
@LekoArts LekoArts modified the milestones: Metadata Management, MDX v2 Jun 24, 2022
@axe312ger axe312ger force-pushed the refactor/mdx-v2-add-toc-and-excerpt branch from 2c2e156 to d673d5c Compare June 27, 2022 07:28
@axe312ger axe312ger force-pushed the feat/mdx-v2-remove-default-layouts branch from fb98492 to 6c8288a Compare June 27, 2022 07:30
Base automatically changed from refactor/mdx-v2-add-toc-and-excerpt to feat/mdx-v2 June 28, 2022 10:51
@axe312ger axe312ger force-pushed the feat/mdx-v2-remove-default-layouts branch from b7bc1c6 to 72061c0 Compare June 28, 2022 11:03
@Khaledgarbaya Khaledgarbaya requested a review from wardpeet June 28, 2022 11:13
@axe312ger axe312ger mentioned this pull request Jun 28, 2022
Merged
21 tasks
axe312ger added a commit that referenced this pull request Jun 28, 2022
@axe312ger
docs: update docs to reflect changes in #35983
939d772
axe312ger
axe312ger commented Jun 29, 2022
View reviewed changes
packages/gatsby/index.d.ts Outdated Show resolved Hide resolved
wardpeet
wardpeet reviewed Jun 29, 2022
View reviewed changes
packages/gatsby-plugin-mdx/src/gatsby-mdx-loader.ts Outdated Show resolved Hide resolved
packages/gatsby-plugin-mdx/src/gatsby-node.ts Outdated Show resolved Hide resolved
packages/gatsby-plugin-mdx/src/gatsby-mdx-loader.ts Outdated Show resolved Hide resolved
packages/gatsby-plugin-mdx/src/gatsby-mdx-loader.ts Show resolved Hide resolved
packages/gatsby-plugin-mdx/src/plugin-options.ts Outdated Show resolved Hide resolved
packages/gatsby-plugin-mdx/src/gatsby-layout-loader.ts Outdated Show resolved Hide resolved
packages/gatsby-plugin-mdx/src/gatsby-layout-loader.ts Outdated Show resolved Hide resolved
packages/gatsby-plugin-mdx/src/gatsby-layout-loader.ts Outdated Show resolved Hide resolved
packages/gatsby/index.d.ts Outdated Show resolved Hide resolved
packages/gatsby/src/utils/js-chunk-names.ts Outdated Show resolved Hide resolved
@axe312ger axe312ger force-pushed the feat/mdx-v2-remove-default-layouts branch from 21f2dfa to 6f17820 Compare June 29, 2022 11:30
@axe312ger
Copy link
Collaborator Author

We still get this warning, any clues how to suppress it?

16:34:37 PM:
warning The GraphQL query in the non-page component "/usr/src/app/www/src/templates/javascript.js" will not be run.

16:34:37 PM:
warning The GraphQL query in the non-page component "/usr/src/app/www/src/templates/post.js" will not be run.

16:34:37 PM:
warning The GraphQL query in the non-page component "/usr/src/app/www/src/templates/tip.js" will not be run.

axe312ger and others added 19 commits July 1, 2022 14:17
@axe312ger
fix: chunk names now should no more exceed max file path length
2fd868c
@axe312ger
fix too long chunk names
89c262b
@axe312ger
fix: ensure page component validation uses clear path
9f63b0a
@axe312ger
fix: properly set clean path on all page component validations
c427068
@axe312ger
test: add unit test for chunk name shortening
d1deec8
@axe312ger
fix: improve chunk name shortening
f24b92b
@axe312ger
fix: (re)support MDX pages automatically created out of /pages directory
c3e4f5d
@axe312ger
chore: add comments to mdx-layout loader to explain what the AST tran…
65a50ba 
…sformations do
@axe312ger
chore: remove @todo comment
1be80af
@axe312ger
refactor: convert pluginOptions into MdxPluginOptions instead of exte…
fe02a53 
…nding PluginOptions
@axe312ger
refactor: rename __mdxPath to __contentFilePath
7f0566f
@axe312ger
refactor: move page component path splitting logic to gatsby-core-utils
8c702e5
@axe312ger
refactor: shorten chunk name to 60 characters and hash it
3928158
@LekoArts @axe312ger
fix indentation
e028af0
@LekoArts @axe312ger
remove unused prop
e4af681
@LekoArts @axe312ger
tmp
7811e04
@axe312ger
feat: add caching to frontmatter extraction
f7c0b89
@axe312ger
feat: support page component URIs in page tree rendering
b4199c1
@axe312ger
perf: ensure frontmatter is parsed as yaml only
9d6b215
@axe312ger axe312ger force-pushed the feat/mdx-v2-remove-default-layouts branch from 3bca15a to 9d6b215 Compare July 1, 2022 12:18
@LekoArts LekoArts merged commit 762b146 into feat/mdx-v2 Jul 4, 2022
@LekoArts LekoArts deleted the feat/mdx-v2-remove-default-layouts branch July 4, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

@wardpeet wardpeet Awaiting requested review from wardpeet

Assignees

@axe312ger axe312ger

Labels
topic: remark/mdx Related to Markdown, remark & MDX ecosystem
Projects
None yet
Milestone
MDX v2
Development

Successfully merging this pull request may close these issues.
3 participants
@axe312ger @wardpeet @LekoArts