perf(gatsby): don't create Head modules in develop if it's not used #37619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
force-pushed
the
perf-head-async-r
branch
from
f2583bb to
34b31a9
Compare
pieh
force-pushed
the
perf-head-async-r
branch
from
34b31a9 to
877db3c
Compare
pieh
added
topic: core
2 tasks
|
The failing tests uncovered at least some issues in |
LekoArts
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, in develop we create
Headmodules for every page template even if that template doesn't actually implementHead. Theorhetically this would be fine, but on larger projects this result in quite an increase of needed memory by webpack compilation, so this PR is crude way to limit impact of it by allowing memory usage be more in line with what it used to be beforeHeadAPI was introduced.As we do want people to use that API over alternatives we will have to figure out how memory usage can be optimized when
Headis actually implemented by templatesDocumentation
Related Issues
#36899