-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable source maps in production (v2) #3818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping on this!
// sure that your web server restricts access to them (e.g. with | ||
// basic auth): | ||
// | ||
// exports.modifyWebpackConfig = ({ config, stage }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API for modifying webpack config has changed. Instead of directly mutating the webpack config, there's a new action named setWebpackConfig
. If you grep the v2 branch, you'll find a number of usages for this + I think there's docs already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fixed.
Hmmmm... so I might have changed my mind about this. I agree with @jquense (#3817 (comment)) that they're more useful than not. Instead of disabling it by default — how about instead we a) investigate using relative paths, removing comments and otherwise making them more tidy by default and b) add a plugin to easily disable producing source maps by modifying the webpack config which also conveniently would speed up builds some. |
Fixes #3817