Show errors during static page generation #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when errors were thrown during static page rendering, they were swallowed by static-site-generator-webpack-plugin and the page was rendered with blank content. This commit adds a check to stats.hasErrors() and returns the error string from stats to the callback. However, the stats object does not expose the original errors, so we also print the stack trace to make it possible to debug errors only thrown during server rendering.
KyleAMathews
added a commit
that referenced
this pull request
Sep 23, 2015
Show errors during static page generation
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
* fix auto fixable ESLint warnings * use .jsx file extension * move Header into it's own component * use .js insteda of .jsx file extension * format code using prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when errors were thrown during static page rendering, they
were swallowed by static-site-generator-webpack-plugin and the page was
rendered with blank content.
This commit adds a check to stats.hasErrors() and returns the error
string from stats to the callback. However, the stats object does not
expose the original errors, so we also print the stack trace to make
it possible to debug errors only thrown during server rendering.