Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Change --no-* commands to --disable-* #4832

Closed
wants to merge 1 commit into from

Conversation

tsriram
Copy link
Contributor

@tsriram tsriram commented Apr 4, 2018

Resolves #4820

@ghost ghost assigned tsriram Apr 4, 2018
@ghost ghost added the review label Apr 4, 2018
@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit 949b3f2

https://deploy-preview-4832--using-drupal.netlify.com

@borekb
Copy link
Contributor

borekb commented Apr 4, 2018

Sorry that I was late to comment but I think --no-xyz is better than --disable-xyz (the --no- prefix seems to be preferred by most CLIs). Originally commented here: #4820 (comment)

A possible way to "fix" the --no-uglify parsing is to configure yargs with boolean-negation: false or maybe define the uglify parameter and let yargs do its negation magic.

@tsriram
Copy link
Contributor Author

tsriram commented Apr 7, 2018

Hmm, I'm quite not sure which is better. Will let @KyleAMathews take a call 😄

Feel free to close this PR if --no-* prefix is the way we want to go.

@KyleAMathews
Copy link
Contributor

Yeah, actually just defining uglify and setting it to default to true sounds like a good solution. Can we only show --no-uglify in the docs?

@tsriram
Copy link
Contributor Author

tsriram commented Apr 8, 2018

Yeah, we can set uglify to true by default, but we'll have to remove boolean-negation option to let users use --no-uglify as a command.

"boolean-negation": false

I couldn't find a way to show only --no-uglify in the docs!

@m-allanson m-allanson removed the review label Apr 13, 2018
@m-allanson
Copy link
Contributor

Maybe the docs message could be something like:

Uglify JS bundles. Defaults to true. For debugging use --no-uglify to build with non-uglified JS bundles.

@tsriram
Copy link
Contributor Author

tsriram commented Apr 17, 2018

Hmm, that could work. Looking at @KyleAMathews' comment #4820 (comment), I'm not sure if we just want to leave the command as is & close this PR? Happy to make the change if we want to get this in.

@m-allanson
Copy link
Contributor

Hmm. Let's close this for now and revisit if needed. Thanks @tsriram, as always!

@m-allanson m-allanson closed this Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants