Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tutorial] Add notice regarding 4-part tutorial near the top #5673

Closed
wants to merge 2 commits into from
Closed

[Tutorial] Add notice regarding 4-part tutorial near the top #5673

wants to merge 2 commits into from

Conversation

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 2, 2018

Deploy preview for using-drupal ready!

Built with commit 9fa938b

https://deploy-preview-5673--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jun 2, 2018

Deploy preview for gatsbygram ready!

Built with commit 9fa938b

https://deploy-preview-5673--gatsbygram.netlify.com

@m-allanson
Copy link
Contributor

m-allanson commented Jun 4, 2018

m-allanson
m-allanson previously approved these changes Jun 4, 2018
@m-allanson m-allanson requested a review from shannonbux June 4, 2018 12:59
@m-allanson
Copy link
Contributor

m-allanson commented Jun 7, 2018

Coming back to this - the note feels a bit too prominent to me.

One idea on condensing it would be:

  • Drop the note from part 4
  • For the remaining parts include the note with just a link back to part 4

Something like:

This tutorial is part of a series about Gatsby's data layer, make sure you've gone through part X before continuing here.

On parts 6 and 7 this could be extended with Are you new here? Jump back to the start of this tutorial series.

Thoughts @fk @shannonbux @ryanditjia?

@ryanditjia
Copy link
Contributor Author

I agree with my implementation being too prominent! I will tone it down by shortening to concise sentences that you suggested. And, even better, we can replace blockquote with the Butler component. I’ve suggested implementing Butler + MDX in the issue, let’s wait for the responses!

@m-allanson
Copy link
Contributor

@ryanditjia it'd be great to get a first version of this merged, then maybe it can be re-visited once there's a proper Butler callout component.

If you have time to finish this up then I think the least work to getting it merged would be:

  • revert the example code changes, as there are newer updates here that are causing merge conflicts
  • update the text of the notices based on my earlier comment

I think that's it!

@ryanditjia
Copy link
Contributor Author

Apologies for letting this go stale for so long. Seems like it’s easier for me to close this and send another PR, doing that now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants