Updating docs contribution guidelines #9889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you think the changes make sense?
amberleyromo
approved these changes
Nov 28, 2018
DSchau
added a commit
to DSchau/gatsby
that referenced
this pull request
Dec 4, 2018
Previously, this was mostly working (see gatsbyjs#9889 where the unit tests are not run, but the e2e tests are run), but as is evident, the e2e tests are still run. This is because the "merging" of template inclusions doesn't work quite like we'd expect, so need to iron that out. This should iron it out!
pieh
pushed a commit
that referenced
this pull request
Dec 4, 2018
Previously, this was mostly working (see #9889 where the unit tests are not run, but the e2e tests are run), but as is evident, the e2e tests are still run. This is because the "merging" of template inclusions doesn't work quite like we'd expect, so need to iron that out. This should iron it out!
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
* Updating docs contribution guidelines Do you think the changes make sense? * Update how-to-contribute.md * Update how-to-contribute.md * Update starter library development section * prettier
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
Previously, this was mostly working (see gatsbyjs#9889 where the unit tests are not run, but the e2e tests are run), but as is evident, the e2e tests are still run. This is because the "merging" of template inclusions doesn't work quite like we'd expect, so need to iron that out. This should iron it out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you think these changes make sense?