This repository has been archived by the owner on Apr 8, 2020. It is now read-only.
fix(invite-collaborator): only create comment if invitation succeeds #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
requested review from
pieh and
m-allanson
and removed request for
pieh
|
Running Prettier on the entire repo and rebasing this. Hold on, please. Edit: Merge #72 first so that diffs are more readable |
sidharthachatterjee
force-pushed
the
fix/do-not-comment-if-inviting-a-user-failed
branch
from
b093ae2 to
de987a6
Compare
sidharthachatterjee
force-pushed
the
fix/do-not-comment-if-inviting-a-user-failed
branch
from
de987a6 to
18a1fbe
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our bot creates a comment on a merged pull request even if inviting the user fails (happens when the user is a bot)
See an instance of this in gatsbyjs/gatsby#11432
This PR fixes this and adds a test asserting this behaviour
Fixes #70