add regex support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
caelean
commented
Feb 23, 2024
caelean
commented
- update with regex support
- updated tests
- update docs
emdoyle
reviewed
Feb 23, 2024
README.md
Outdated
| ```python | ||
| @modguard.public(allowlist=['utils.helpers']) | ||
| @modguard.public(allowlist=['utils.helpers', r'.*aux.*']) |
There was a problem hiding this comment.
Might be more readable to use a realistic example like r'core\.project\.*' or similar
emdoyle
reviewed
Feb 23, 2024
README.md
Outdated
|
|
||
| ``` | ||
| This will allow for `public_function` and `PUBLIC_CONSTANT` to be imported and used in `utils.helpers`, but restrict its usage elsewhere. | ||
| This will allow for `public_function` and `PUBLIC_CONSTANT` to be imported and used in `utils.helpers` and any matching regex to `.*aux.*`, but restrict its usage elsewhere. |
There was a problem hiding this comment.
Suggested change
| This will allow for `public_function` and `PUBLIC_CONSTANT` to be imported and used in `utils.helpers` and any matching regex to `.*aux.*`, but restrict its usage elsewhere. | |
| This will allow for `public_function` and `PUBLIC_CONSTANT` to be imported and used in `utils.helpers` and any module whose path matches the regex `.*aux.*`, but restrict its usage elsewhere. |
emdoyle
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.