Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove searching for *.yaml files #3

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

Blast545
Copy link
Contributor

CONTEXT

Introducing this PR: gazebosim/gz-fuel-tools#423

Made our debbuilders start to fail on jammy and noble, see:
https://build.osrfoundation.org/job/gz-fuel-tools10-debbuilder/365/ (jammy)
https://build.osrfoundation.org/job/gz-fuel-tools10-debbuilder/364/ (noble)

The error is:

dh_install: warning: Cannot find (any matches for) "usr/share/gz/*/*.yaml" (tried in ., debian/tmp)

dh_install: warning: libgz-fuel-tools10 missing files: usr/share/gz/*/*.yaml
dh_install: error: missing files, aborting
make: *** [debian/rules:5: binary] Error 25

Solution

With this PR, the line searching for yaml files will be removed. This was needed earlier because there was a conf.yaml file that was removed starting on fuel_tools9, I think it's not needed anymore. Happy to iterate if my assumption is wrong.

@Blast545
Copy link
Contributor Author

PTAL: @j-rivero @azeey

@j-rivero
Copy link
Contributor

The change seems fine to me although I don't have the context of when the file was removed from gz-fuel-tools9.

@azeey azeey merged commit 553d54e into gazebo-release:main Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants