This repository has been archived by the owner on Dec 29, 2020. It is now read-only.
Minimum versions for Ignition dependencies #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
This was referenced May 20, 2020
j-rivero
suggested changes
May 20, 2020
Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
Thanks, done! |
j-rivero
approved these changes
May 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation is that right now, if a user only calls
sudo apt install libignition-gazebo2to upgrade only this package, they end up with a broken system because the dependencies are not up-to-date. The result is a runtime error when runningign gazeboand it can't load the library.I based myself on the versions currently required on ign-gazebo's CMakeLists, but we haven't been very good about updating these, so some could be out of date.
Also see gazebosim/gz-sim#148.