Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focal support #19

Merged
merged 3 commits into from
Jul 31, 2020
Merged

Focal support #19

merged 3 commits into from
Jul 31, 2020

Conversation

chapulina
Copy link
Contributor

The focal branch was branched off #17 .

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from mjcarroll July 29, 2020 20:29
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

@j-rivero , gzdev seems to be having some trouble on Focal, see the results from using this branch on gazebosim/gz-math#139:

2020-07-29T21:18:53.8458438Z + /tmp/gzdev/gzdev.py repository enable --project=ignition-math6
2020-07-29T21:18:53.9206193Z Traceback (most recent call last):
2020-07-29T21:18:53.9209613Z   File "/tmp/gzdev/plugins/repository.py", line 84, in get_linux_distro
2020-07-29T21:18:53.9211127Z     distro_str = distro.linux_distribution()[0]
2020-07-29T21:18:53.9211930Z NameError: name 'distro' is not defined
2020-07-29T21:18:53.9212021Z 
2020-07-29T21:18:53.9212192Z During handling of the above exception, another exception occurred:
2020-07-29T21:18:53.9212308Z 
2020-07-29T21:18:53.9212468Z Traceback (most recent call last):
2020-07-29T21:18:53.9212628Z   File "/tmp/gzdev/gzdev.py", line 35, in <module>
2020-07-29T21:18:53.9212797Z     plugin.main()
2020-07-29T21:18:53.9212975Z   File "/tmp/gzdev/plugins/repository.py", line 192, in main
2020-07-29T21:18:53.9213151Z     process_input(args, config)
2020-07-29T21:18:53.9213355Z   File "/tmp/gzdev/plugins/repository.py", line 181, in process_input
2020-07-29T21:18:53.9213544Z     install_repos(project_list, config, linux_distro)
2020-07-29T21:18:53.9213723Z   File "/tmp/gzdev/plugins/repository.py", line 125, in install_repos
2020-07-29T21:18:53.9214152Z     install_repo(p['name'], p['type'], config, linux_distro)
2020-07-29T21:18:53.9214341Z   File "/tmp/gzdev/plugins/repository.py", line 128, in install_repo
2020-07-29T21:18:53.9214525Z     url = get_repo_url(repo_name, repo_type, config)
2020-07-29T21:18:53.9214709Z   File "/tmp/gzdev/plugins/repository.py", line 104, in get_repo_url
2020-07-29T21:18:53.9215145Z     if p['name'] == repo_name and p['linux_distro'].lower() == get_linux_distro():
2020-07-29T21:18:53.9215346Z   File "/tmp/gzdev/plugins/repository.py", line 86, in get_linux_distro
2020-07-29T21:18:53.9215535Z     distro_str = platform.linux_distribution()[0]
2020-07-29T21:18:53.9215941Z AttributeError: module 'platform' has no attribute 'linux_distribution'

@@ -7,6 +7,8 @@ OLD_APT_DEPENDENCIES=$1
CODECOV_TOKEN=$2
CMAKE_ARGS=$3

export DEBIAN_FRONTEND="noninteractive"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be backported into the bionic branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's not causing errors there, I think it's best to. I'll do it once this PR is in.

@j-rivero
Copy link
Contributor

@j-rivero , gzdev seems to be having some trouble on Focal, see the results from using this branch on ignitionrobotics/ign-math#139:

Ouch, this should fix it gazebo-tooling/gzdev#15

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

ign-math is happy, so this first iteration is gtg

@chapulina chapulina merged commit 00860b9 into focal Jul 31, 2020
@chapulina chapulina deleted the chapulina/focal branch July 31, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants