Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try checking out ci_matching_branch for gzdev #46

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Dec 9, 2021

Code copied from release-tools#572 with the magic ${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}} copied from drake_vendor's CI configuration to return the current branch for both GitHub workflow Push and Pull-Request events.

Testing with gazebosim/sdformat#780 since it needs the ign-cmake2 2.10.0~pre1 prerelease and a matching gzdev branch:

Note that the focal workflows are failing on that PR. I'll update the focal branch once this is merged.

Code copied from release-tools#572

Signed-off-by: Steve Peters <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we keep the --depth 1?

@scpeters
Copy link
Contributor Author

scpeters commented Dec 9, 2021

LGTM. Can we keep the --depth 1?

it's complicated to switch branches when you clone with --depth 1, so I removed it here and also in gazebo-tooling/release-tools#572

I don't think gzdev is particularly large, so it seems like a small cost

@scpeters scpeters merged commit c859eba into bionic Dec 9, 2021
@scpeters scpeters deleted the ci_matching_branch_bionic branch December 9, 2021 21:28
scpeters added a commit that referenced this pull request Dec 9, 2021
Code copied from release-tools#572

Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit that referenced this pull request Dec 9, 2021
Code copied from release-tools#572

Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit that referenced this pull request Apr 6, 2022
Code copied from release-tools#572

Signed-off-by: Steve Peters <[email protected]>
chapulina pushed a commit that referenced this pull request Apr 6, 2022
Code copied from release-tools#572

Signed-off-by: Steve Peters <[email protected]>
chapulina pushed a commit that referenced this pull request Apr 7, 2022
* Try checking out ci_matching_branch for gzdev (#46)

Code copied from release-tools#572

Signed-off-by: Steve Peters <[email protected]>

* Update focal to use gcc9

Signed-off-by: Michael Carroll <[email protected]>

Co-authored-by: Michael Carroll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants