Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support compiling dependencies from source #7

Merged
merged 14 commits into from
May 13, 2020
Merged

Support compiling dependencies from source #7

merged 14 commits into from
May 13, 2020

Conversation

chapulina
Copy link
Contributor

Sometimes we want to compile some Ignition dependency from source. For example, when developing the next release, or for testing PRs.

Resolves #5

chapulina added 5 commits May 1, 2020 14:17
@chapulina
Add script hooks
12ab33f 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
fix vars, add echos
18865c2 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
add script after make test
27dc5ba 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Support compiling dependencies from source
a67c0cc 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
docs
a5e593d 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina linked an issue May 8, 2020 that may be closed by this pull request
Build Ignition dependencies from source #5
Closed
This was referenced May 8, 2020
Merged
Merged
Merged
Merged
@chapulina chapulina requested a review from j-rivero May 11, 2020 18:22
@chapulina chapulina changed the base branch from script_hooks to master May 11, 2020 21:24
chapulina added 9 commits May 11, 2020 14:25
@chapulina
fixed conflicts
6fe6c6a 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
use colcon to build libs in correct order
48d0fbb 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
upgrade pip
4d57ad7 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
python3
7f708ae 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
3?
f8c9186 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
hardcode file path
cfdcdc6 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
remove source deps
e74558f 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
wrong level
1fe1fe8 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
correct foldervi entrypoint.sh
435c458 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

@j-rivero , all downstream libraries are being built successfully with this branch and all those PRs have been approved.

j-rivero
j-rivero approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.
Out of the scope of this PR: I noticed that we are using set -x in entrypoint.sh script, I miss a set -e to stop on errors, not sure that behavior is in effect by using other mechanisms.

@chapulina
Copy link
Contributor Author

I miss a set -e to stop on errors, not sure that behavior is in effect by using other mechanisms.

Thanks for the tip, I'll look into this while addressing #6

@chapulina chapulina merged commit 0bbce7f into master May 13, 2020
@chapulina chapulina deleted the ign_from_src branch May 13, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Ignition dependencies from source
2 participants
@chapulina @j-rivero