Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass CMake args #9

Merged
merged 1 commit into from
May 19, 2020
Merged

Add ability to pass CMake args #9

merged 1 commit into from
May 19, 2020

Conversation

mjcarroll
Copy link
Contributor

In support of disabling "examples" by default in ign-cmake, we would like for them to run in CI, which requires passing an enabling flag.

Signed-off-by: Michael Carroll [email protected]

@mjcarroll mjcarroll added the enhancement New feature or request label May 19, 2020
@mjcarroll mjcarroll requested a review from chapulina May 19, 2020 13:20
@mjcarroll mjcarroll self-assigned this May 19, 2020
@mjcarroll
Add ability to pass CMake args
efcfd44 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll mentioned this pull request May 19, 2020
Merged
chapulina
chapulina approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chapulina chapulina merged commit fea60bd into master May 19, 2020
@chapulina chapulina deleted the cmake_args branch May 19, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@mjcarroll mjcarroll

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @chapulina