ign-plugin2.yaml: add ign-utils1 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
adlarkin
reviewed
Jul 26, 2021
There was a problem hiding this comment.
LGTM. I'll let @chapulina take a look as well. In what contexts are we using ign-plugin2? I'm only aware of ign-plugin1. I don't see a ign-plugin2 branch at https://github.com/ignitionrobotics/ign-plugin
chapulina
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
I'm only aware of ign-plugin1. I don't see a ign-plugin2 branch
That's the unreleased version on the main branch.
In what contexts are we using ign-plugin2?
It's not planned to go into Fortress, so for the moment it's just where we put breaking changes that can't go into ign-plugin1. It may be part of a future collection if we see the need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by osrf/homebrew-simulation#1540