Add a check to avoid infinite number of builds archived by a job

Signed-off-by: Jose Luis Rivero <[email protected]>

jenkins-scripts/dsl/dsl_checks.bash

@@ -63,8 +63,6 @@ if [[ -n ${empty_branches_on_github_triggered} ]]; then
   exit 1
 fi
 
-# re-enable after https://github.com/gazebo-tooling/release-tools/issues/1095
-
 # Filter out the previous auto jobs
 filtered_dir=$(mktemp -d)
 cp -- *-abichecker-*.xml "${filtered_dir}"
@@ -76,3 +74,11 @@ if [[ -n ${repeated} ]]; then
    echo "please exclude one of the versions in the yaml file to reduce the server workload"
    exit 1
 fi
+
+avoid_infinite_build_archive=$(grep '<numToKeep>-1</numToKeep>' -- *.xml)
+if [[ -n ${avoid_infinite_build_archive} ]]; then
+  echo "Found a job setup to keep infinite number of builds. This is BAD"
+  echo "${}"
+  exit 1
+fi
+