Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jetty collection to gz-collections.yaml #1199

Merged
merged 8 commits into from
Nov 12, 2024

Conversation

Crola1702
Copy link
Contributor

As the title says

Signed-off-by: Crola1702 <[email protected]>
@Crola1702 Crola1702 self-assigned this Nov 6, 2024
@Crola1702 Crola1702 requested a review from j-rivero as a code owner November 6, 2024 14:02
@j-rivero
Copy link
Contributor

j-rivero commented Nov 6, 2024

If I'm not wrong the appointed branches for Jetty are already setup in gazebo-tooling/gazebodistro#181 and should be the same here. So no main branches but probably starting with Ionic branches.

Signed-off-by: Crola1702 <[email protected]>
@Crola1702
Copy link
Contributor Author

So no main branches but probably starting with Ionic branches.

Done. Can you check if everything is correct? @j-rivero

@Crola1702 Crola1702 requested a review from azeey November 6, 2024 21:09
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that major_version are not in sync with the package names. I.e: gz-cmake4 branch for gz-cmake5 package. So we need to update the major_versions too.

@Crola1702 Crola1702 requested a review from j-rivero November 11, 2024 12:16
Signed-off-by: Crola1702 <[email protected]>
@Crola1702 Crola1702 requested a review from azeey November 12, 2024 17:21
@Crola1702 Crola1702 merged commit 4c9efb4 into master Nov 12, 2024
@Crola1702 Crola1702 deleted the Crola1702/add-jetty-collection branch November 12, 2024 20:47
@iche033 iche033 mentioned this pull request Nov 18, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants