ignition-abichecker: set GZDEV_PROJECT_NAME #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ABI_JOB_SOFTWARE_NAME variable is currently "ign-${IGN_DESIGNATION}",
so expand "ign-" to "ignition-" and append the major version.
Also remove some old code that was enabling prerelease repos.
Signed-off-by: Steve Peters <[email protected]>
j-rivero
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while reviewing gazebosim/gz-physics#86 that the ignition ABI checker jenkins jobs aren't setting the
GZDEV_PROJECT_NAMEvariable, since I enabled prerelease repositories forignition-physics2in gazebo-tooling/gzdev#16 which fixed the other Ubuntu jobs but not the ABI checker.The
ABI_JOB_SOFTWARE_NAMEvariable is currentlyign-${IGN_DESIGNATION}, so expand "ign-" to "ignition-" and append the major version.Also removes some old code that was enabling prerelease repos.
Signed-off-by: Steve Peters [email protected]