Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to bump a library's version in the upcoming collection #333

Merged
merged 15 commits into from
Apr 29, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Oct 29, 2020

I used iterations of this script to open all the pull requests connected to #331, except for the gzdev one.

The script still needs a lot of work, but it's a great improvement over doing all of that by hand. Some TODO items that stand out:

  • The script relies on most of the PRs not being merged. After Bump in edifice: ign-rendering to 5 gazebodistro#13 was merged, I had to pin to the previous commit.
  • Running the script twice shouldn't change the output.
  • The release-tools part still has a manual step
  • Updating gzdev is not included yet
  • Updating ign-edifice, ign-edifice-release and ign-edifice on homebrew ff4ac9c
  • The coloring could be more consistent to make it easier to navigate the logs

We'll have a chance to test this script again soon when we bump sdformat and dependencies for Edifice.

Also started a README so we can start documenting what's in this repository to improve discoverability.

Signed-off-by: Louise Poubel <[email protected]>
Nate Koenig and others added 3 commits December 23, 2020 15:51
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Michael Carroll <[email protected]>
@chapulina chapulina marked this pull request as ready for review January 7, 2021 22:33
@chapulina chapulina requested a review from j-rivero as a code owner January 7, 2021 22:33
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

This script was used to address #331, #360, #361 and #362. It still requires some manual cleanup here and there, but in general I think it's a large speed up over doing all this manually. There's a lot of room for improvement, for example, using the GitHub cli to open PRs with the correct text would help even more. I wish someone else had had the chance to use it until the end, but unfortunately time didn't permit 😕

My suggestion is to get this in for now and work on improvements on top of it as we go. Let me know what you'd prefer, @j-rivero .

@j-rivero
Copy link
Contributor

confused

My suggestion is to get this in for now and work on improvements on top of it as we go. Let me know what you'd prefer, @j-rivero .

I agree with merging current limited support and keep improving it as long as the features enter into plans or a bit of free time to do them appear.

@chapulina
Copy link
Contributor Author

I agree with merging current limited support

Thanks, Jose! The script is in a intermediate state right now while I transition to the latest format:

  • Open separate gazebodistro PRs for each library
  • Open PRs automatically using the gh CLI
  • Enable nightlies for the bumped versions

I hope to wrap it up by the end of the day and trigger all PRs for #428 , and then we can merge it and revisit it for Ign-G.

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

Ok, I triggered all PRs in #428 using the latest version of the script. I think this is good as a first revision.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

Merging this for now, we can revisit it when we need it in 6 months 😬

@chapulina chapulina merged commit a566144 into master Apr 29, 2021
@chapulina chapulina deleted the chapulina/bump_deps branch April 29, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants