-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to bump a library's version in the upcoming collection #333
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
This script was used to address #331, #360, #361 and #362. It still requires some manual cleanup here and there, but in general I think it's a large speed up over doing all this manually. There's a lot of room for improvement, for example, using the GitHub cli to open PRs with the correct text would help even more. I wish someone else had had the chance to use it until the end, but unfortunately time didn't permit 😕 My suggestion is to get this in for now and work on improvements on top of it as we go. Let me know what you'd prefer, @j-rivero . |
Signed-off-by: Louise Poubel <[email protected]>
I agree with merging current limited support and keep improving it as long as the features enter into plans or a bit of free time to do them appear. |
Thanks, Jose! The script is in a intermediate state right now while I transition to the latest format:
I hope to wrap it up by the end of the day and trigger all PRs for #428 , and then we can merge it and revisit it for Ign-G. |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Ok, I triggered all PRs in #428 using the latest version of the script. I think this is good as a first revision. |
Signed-off-by: Louise Poubel <[email protected]>
Merging this for now, we can revisit it when we need it in 6 months 😬 |
I used iterations of this script to open all the pull requests connected to #331, except for the
gzdev
one.The script still needs a lot of work, but it's a great improvement over doing all of that by hand. Some TODO items that stand out:
release-tools
part still has a manual stepgzdev
is not included yetUpdatingff4ac9cign-edifice
,ign-edifice-release
andign-edifice
on homebrewWe'll have a chance to test this script again soon when we bump
sdformat
and dependencies for Edifice.Also started a README so we can start documenting what's in this repository to improve discoverability.