Add CI jobs for garden branches #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename supported_branches to supported_ign_branches in preparation for supported_gz_branches. Signed-off-by: Steve Peters <[email protected]>
Add separate logic for gz-* branches. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
chapulina
reviewed
Aug 10, 2022
There was a problem hiding this comment.
Thanks for getting this going! CC @j-rivero who was assigned to this task.
- Part of Release Garden #578
| supported_gz_branches("${gz_software}").each { major_version -> | ||
| if (major_version) { | ||
| // No 1-debbuild versions, they use the unversioned job | ||
| if ("${major_version}" == "0" || "${major_version}" == "1" ) |
There was a problem hiding this comment.
We don't have any libraries in this situation, but I imagine it could happen in the future if we add a new library
Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
chapulina
reviewed
Aug 10, 2022
Signed-off-by: Steve Peters <[email protected]>
|
testing for sdformat: |
the ABI checker job is now triggering for |
|
@j-rivero @chapulina would you like to see further testing of this? I've tested the sdformat changes, and could deploy the ignition changes as well if you'd like to see that tested before merging |
Yeah I was hoping to trigger one of those since the ignition DSL is separate from SDF |
|
deploying: it looks like this creates duplicate deb builder jobs:
I'll redact the duplication for now so we can fix it later |
Are you removing the |
|
For the CI jobs, will the |
Signed-off-by: Steve Peters <[email protected]>
Remove garden jobs from extra_debbuild array. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
I'm removing the |
all the jenkins job names should still start with |
Signed-off-by: Steve Peters <[email protected]>
|
new test: but it's missing some |
that didn't do what I intended; I think I'll revert it https://build.osrfoundation.org/job/_dsl_ignition/1362/console |
This reverts commit 8c84a3c. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
|
fresh deployment: all existing jobs are preserved, but the |
|
ABI job is now triggering properly in gazebosim/gz-math#481 |
chapulina
approved these changes
Aug 12, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the
supported_branchesmethod inignition.dsltosupported_ign_branches(eab7c8e) and adds a parallelsupported_gz_branchesmethod that draws from agz_branchesdata structure (9ab203a). It also adds thesdf13branch insdformat.dsl(558d0e6).The code duplication could potentially be reduced with some refactoring, but I think this is the easiest way to get CI working for our garden branches.