Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unofficial ros_gz: add a smoke test to detect ABI breakages #950

Merged
merged 32 commits into from
Jun 6, 2023

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Jun 2, 2023

Part of #895

The pull request add an smoke test to the buildfarm that is designed to mainly identify extreme breakages in the software with the eyes set on any possible ABI disruptive change that ROS dependencies of the wrappers could execute. To do so, the testing does:

  • Reproduce ros_gz talker/listener and check for expected output
  • Execute ros2 launch ros_gz_sim gz_sim.launch.py gz_args:=shapes.sdf and leave it for 3 min checking that indeed it has been running for 3min.

Not very serious tests but should serve us to detect heavy problems.

Bonus: remove of an old file in this PR not used anymore.

j-rivero and others added 30 commits May 10, 2023 17:31
Obsolete file. removed

Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
 * Python3 modifications
 * Update ROS2 distros

Signed-off-by: Jose Luis Rivero <[email protected]>
* Create a Groovy script to apply singleton labels.

I think this script will need to be run as a system groovy script rather
than with the sandbox. I have successfully tested it using the Jenkins
script console.

* Add a comment describing the form.

I'd like to make this a struct/class but I'm not quite sure yet.

* Replace shuffle with an in-place pick of a random number.

I was bending around the immutable set in order to use shuffle. But this
is much shorter and makes me happier.

* Add a global coment in the file

Signed-off-by: Jose Luis Rivero <[email protected]>

* Add the _nightly_node_labeler DSL job

Signed-off-by: Jose Luis Rivero <[email protected]>

* Filter nodes to only online nodes

Signed-off-by: Jose Luis Rivero <[email protected]>

* Mark build as unstable if labels were not set correctly

Signed-off-by: Jose Luis Rivero <[email protected]>

* Support for cron operations on nightly preparation

Signed-off-by: Jose Luis Rivero <[email protected]>

* Mark build unstable for non expected scenarios

Signed-off-by: Jose Luis Rivero <[email protected]>

* Fix path expected by Jenkins

Signed-off-by: Jose Luis Rivero <[email protected]>

---------

Signed-off-by: Jose Luis Rivero <[email protected]>
Co-authored-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero
Copy link
Contributor Author

j-rivero commented Jun 2, 2023

Tested: Build Status

@j-rivero j-rivero merged commit b59f397 into master Jun 6, 2023
@j-rivero j-rivero deleted the jrivero/ros_gz_release branch June 6, 2023 16:22
j-rivero added a commit that referenced this pull request Jun 28, 2023
Smoke test designed to mainly identify extreme breakages in the software with the eyes set on any possible ABI disruptive change that ROS dependencies of the wrappers could execute. To do so, the testing does:
 * Reproduce ros_gz talker/listener and check for expected output
 * Execute ros2 launch ros_gz_sim gz_sim.launch.py gz_args:=shapes.sdf and leave it for 3 min checking that indeed it has been running for 3min.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants