-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unofficial ros_gz: add a smoke test to detect ABI breakages #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Obsolete file. removed Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
* Python3 modifications * Update ROS2 distros Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
* Create a Groovy script to apply singleton labels. I think this script will need to be run as a system groovy script rather than with the sandbox. I have successfully tested it using the Jenkins script console. * Add a comment describing the form. I'd like to make this a struct/class but I'm not quite sure yet. * Replace shuffle with an in-place pick of a random number. I was bending around the immutable set in order to use shuffle. But this is much shorter and makes me happier. * Add a global coment in the file Signed-off-by: Jose Luis Rivero <[email protected]> * Add the _nightly_node_labeler DSL job Signed-off-by: Jose Luis Rivero <[email protected]> * Filter nodes to only online nodes Signed-off-by: Jose Luis Rivero <[email protected]> * Mark build as unstable if labels were not set correctly Signed-off-by: Jose Luis Rivero <[email protected]> * Support for cron operations on nightly preparation Signed-off-by: Jose Luis Rivero <[email protected]> * Mark build unstable for non expected scenarios Signed-off-by: Jose Luis Rivero <[email protected]> * Fix path expected by Jenkins Signed-off-by: Jose Luis Rivero <[email protected]> --------- Signed-off-by: Jose Luis Rivero <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
7 tasks
j-rivero
added a commit
that referenced
this pull request
Jun 28, 2023
Smoke test designed to mainly identify extreme breakages in the software with the eyes set on any possible ABI disruptive change that ROS dependencies of the wrappers could execute. To do so, the testing does: * Reproduce ros_gz talker/listener and check for expected output * Execute ros2 launch ros_gz_sim gz_sim.launch.py gz_args:=shapes.sdf and leave it for 3 min checking that indeed it has been running for 3min.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #895
The pull request add an smoke test to the buildfarm that is designed to mainly identify extreme breakages in the software with the eyes set on any possible ABI disruptive change that ROS dependencies of the wrappers could execute. To do so, the testing does:
ros2 launch ros_gz_sim gz_sim.launch.py gz_args:=shapes.sdf
and leave it for 3 min checking that indeed it has been running for 3min.Not very serious tests but should serve us to detect heavy problems.
Bonus: remove of an old file in this PR not used anymore.