Support red skybox

[nkoenig]

Signed-off-by: Nate Koenig [email protected]

As the name suggest, this is a quick hack to get a red skybox working. This approach will be replaced by proper .dds loading when I have more time.

Here is an example SDF file for testing:

<?xml version='1.0' encoding='utf-8'?>
<sdf version="1.9">
  <world name="test">
    <scene>
      <sky>
        <cubemap_uri>/home/nkoenig/skybox_red.dds</cubemap_uri>
      </sky>
    </scene>
    <model name="ground_plane">
      <static>true</static>
      <link name="link">
        <collision name="collision">
          <geometry>
            <plane>
              <normal>0 0 1</normal>
              <size>100 100</size>
            </plane>
          </geometry>
        </collision>
        <visual name="visual">
          <geometry>
            <plane>
              <normal>0 0 1</normal>
              <size>100 100</size>
            </plane>
          </geometry>
          <material>
            <ambient>0.8 0.8 0.8 1</ambient>
            <diffuse>0.8 0.8 0.8 1</diffuse>
            <specular>0.8 0.8 0.8 1</specular>
          </material>
        </visual>
      </link>
    </model>
  </world>
</sdf>

[german-e-mas]

If this asset comes from the websocket, we should pass the websocket loading manager here as well. Check for other cases where it was used.

[nkoenig]

I'm assuming that I'll add all skyboxes to fuel. I'd that okay?

[clalancette]

I'm assuming that I'll add all skyboxes to fuel. I'd that okay?

It looks like this was already done, correct? That is, if I use this branch and add in a cubemap_uri to my SDF, I get a red sky as desired. So I think that means everything was properly downloaded from fuel. Do I have that right?

[german-e-mas]

Yes, that sounds right

[clalancette]

FYI, I rebased this onto the latest gzweb2, and added a few additional checks for null in 90c5b69. Without those, when not specifying a cubemap_uri, I was getting crashes in gzweb.

With that, I was able to test both without a cubemap_uri, where I saw a blue sky, and with a cubemap_uri, where I saw a red sky. I think that makes this a successful hack. I'll speak to @german-e-mas briefly about it to see if there is anything else we should do here.

[clalancette]

This looks good to me now as a temporary hack. I'm just waiting on @ColeOSRF to confirm it works for him before merging.

[ColeOSRF]

Nate if you're able to wrap back around to this later today could you throw update the red skybox with the one in this folder? It also contains the grey sky texture.
https://www.dropbox.com/scl/fo/44xtvz41xi0f8m9a6sh6i/h?dl=0&rlkey=kq8fp9vck5o5hj4h5g2b7r8ei

[nkoenig]

See #42