Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tzdata again, test on push #102

Merged
merged 7 commits into from
Nov 2, 2020
Merged

Fix tzdata again, test on push #102

merged 7 commits into from
Nov 2, 2020

Conversation

chapulina
Copy link
Contributor

#99 didn't do it

This fix is being tested on push. If it works, I'll revert the changes to nightly-upload.yml and open the PR for review.

@chapulina
Fix tzdata again, test on push
e421619 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Oct 8, 2020
@chapulina chapulina added bug Something isn't working infrastructure Requires changes on the web server or other infra labels Oct 8, 2020
@chapulina chapulina marked this pull request as ready for review October 12, 2020 17:50
@chapulina chapulina requested a review from maryaB-osr as a code owner October 12, 2020 17:50
@chapulina chapulina requested a review from caguero October 12, 2020 17:50
@chapulina
Copy link
Contributor Author

Phew, ok, now this is ready to go

@chapulina chapulina marked this pull request as draft October 16, 2020 05:16
@chapulina
Copy link
Contributor Author

Turned it back to draft, now it needs gazebosim/sdformat#392. We're getting there ✊

@chapulina chapulina marked this pull request as ready for review October 31, 2020 01:44
@chapulina
Copy link
Contributor Author

@caguero , this is ready for review again. Blueprint and Dome are stopping at SDFormat because they miss these PRs:

@chapulina
back to schedule
6bcc0b0 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 6e5f3fc into master Nov 2, 2020
@chapulina chapulina deleted the chapulina/tzdata_again branch November 2, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

@maryaB-osr maryaB-osr Awaiting requested review from maryaB-osr

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint bug Something isn't working 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome infrastructure Requires changes on the web server or other infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @caguero