Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake logic for OGRE2.1/OGRE2.2 on Windows #180

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Conversation

mjcarroll
Copy link
Contributor

Redo of #177, which was erroneously adding "debug" include paths and also skipping rendering system plugins for ogre2.1.

I have tested this vs ignition-rendering6 (OGRE 2.1) on beefy as well as @ahcorde's branch (OGRE 2.2) on beefy.

Signed-off-by: Michael Carroll [email protected]

@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Aug 19, 2021
@chapulina
Copy link
Contributor

chapulina commented Aug 19, 2021

Tested against ign-rendering's main branch here: Build Status

And against gazebosim/gz-rendering#272: Build Status

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it works with both Ogre 2.1 and 2.2! Great work! 🎉

@mjcarroll mjcarroll merged commit ea35420 into ign-cmake2 Aug 19, 2021
@mjcarroll mjcarroll deleted the ogre22_win_again branch August 19, 2021 18:48
@chapulina
Copy link
Contributor

It looks like we're still having trouble with this, for example:

https://build.osrfoundation.org/job/ign_rendering-pr-win/1903/console

--- stderr: ignition-rendering6
CMake Warning (dev) at C:/Jenkins/workspace/ign_rendering-pr-win/ws/install/ignition-cmake2/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:385 (message):
   -- THIS MESSAGE IS INTENDED FOR IGNITION-RENDERING AUTHORS --
      (IF YOU SEE THIS, PLEASE REPORT IT)

  Could not find pkg-config information for IgnOGRE.  It was not provided by
  the find-module for the package, nor was it explicitly passed into the call
  to ign_find_package(~).  This is most likely an error in this project's use
  of ign-cmake.
Call Stack (most recent call first):
  CMakeLists.txt:66 (ign_find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at C:/Jenkins/workspace/ign_rendering-pr-win/ws/install/ignition-cmake2/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:385 (message):
   -- THIS MESSAGE IS INTENDED FOR IGNITION-RENDERING AUTHORS --
      (IF YOU SEE THIS, PLEASE REPORT IT)

  Could not find pkg-config information for IgnOGRE2.  It was not provided by
  the find-module for the package, nor was it explicitly passed into the call
  to ign_find_package(~).  This is most likely an error in this project's use
  of ign-cmake.
Call Stack (most recent call first):
  CMakeLists.txt:83 (ign_find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

---
Failed   <<< ignition-rendering6 [4min 20s, exited with code 1]

srmainwaring pushed a commit to srmainwaring/gz-cmake that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants