Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples using static libraries #202

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Dec 29, 2021

🦟 Bug fix

Adding examples that I made for #203, but that code change isn't needed, so just add the examples here.

Summary

This adds an example core_no_deps_static that builds a static library and a second example core_child_use_static that links against that static library.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Dec 29, 2021
@scpeters scpeters closed this Dec 29, 2021
@scpeters scpeters deleted the scpeters/example_use_static_lib branch December 29, 2021 20:16
@scpeters scpeters restored the scpeters/example_use_static_lib branch December 30, 2021 01:12
@scpeters scpeters reopened this Dec 30, 2021
This adds an example that builds a static library
and a second example that links against that static
library.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters force-pushed the scpeters/example_use_static_lib branch from 7865111 to cc69c6c Compare December 30, 2021 19:32
@scpeters scpeters marked this pull request as ready for review December 30, 2021 19:32
@scpeters scpeters mentioned this pull request Dec 30, 2021
7 tasks
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples look okay to me. Does this need to be merged, or was the PR only created for testing/checking CI?

@scpeters
Copy link
Member Author

scpeters commented Jan 7, 2022

Examples look okay to me. Does this need to be merged, or was the PR only created for testing/checking CI?

I made this PR to test some examples for #203 but later realized that the code changes in #203 aren't needed. So this just adds the examples, which have some value on their own

@scpeters scpeters merged commit 3f918e0 into ign-cmake2 Jan 7, 2022
@scpeters scpeters deleted the scpeters/example_use_static_lib branch January 7, 2022 23:54
srmainwaring pushed a commit to srmainwaring/gz-cmake that referenced this pull request Mar 1, 2022
This adds an example that builds a static library
and a second example that links against that static
library.

Signed-off-by: Steve Peters <[email protected]>
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants