Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude proto generated files in coverage test #272

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Exclude proto generated files in coverage test #272

merged 1 commit into from
Jul 8, 2022

Conversation

AzulRadio
Copy link
Contributor

@AzulRadio AzulRadio commented Jul 8, 2022 •
edited by chapulina
Loading

Signed-off-by: youhy [email protected]

Increase the test coverage rate for gz-msgs5 from ~18% to ~85%.

Summary

All codes generated by proto all follow this pattern: *.pb.cc or *.pb.h

To test this, follow https://gazebosim.org/docs/all/contributing#test-coverage to generate coverage report for gz-msgs5

Before:
image

After:
20220708141640

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jul 8, 2022
@chapulina chapulina added the QA Quality assurance. label Jul 8, 2022
chapulina
chapulina approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

@chapulina chapulina enabled auto-merge (squash) July 8, 2022 19:50
@chapulina chapulina merged commit 092f2c8 into ign-cmake2 Jul 8, 2022
@chapulina chapulina deleted the azulradio/msgs_coverage branch July 8, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11 QA Quality assurance.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AzulRadio @chapulina