Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-cmake2 ➡️ gz-cmake3 #322

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Merge ign-cmake2 ➡️ gz-cmake3 #322

merged 3 commits into from
Nov 11, 2022

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port ign-cmake2 ➡️ gz-cmake3

Branch comparison: gz-cmake3...ign-cmake2

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

scpeters and others added 3 commits November 3, 2022 14:45
The FindIgnOGRE2 module makes changes to PKG_CONFIG_PATH
during the search. These changes ensure that the original
value of this environment variable is restored. This also backports
the following fixes from Garden:

* Check that minor version matches.
* Forward the link directories to be used by RPath.
* Unset OGRE2_* variables if not found.

Signed-off-by: Steve Peters <[email protected]>
* Bump version to 2.16.0
* Update changelog

Signed-off-by: Jose Luis Rivero <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 11, 2022
@scpeters scpeters mentioned this pull request Nov 11, 2022
7 tasks
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking into this yesterday and seems like I was lost in the merge of FindGzOGRE2 and tough that all the changes were already merged.

Thanks for catching.

@scpeters
Copy link
Member Author

I was looking into this yesterday and seems like I was lost in the merge of FindGzOGRE2 and tough that all the changes were already merged.

Thanks for catching.

the conflicts are quite tricky these days, but I made the PR for #319, so I knew what to expect

@scpeters scpeters merged commit 51309b1 into gz-cmake3 Nov 11, 2022
@scpeters scpeters deleted the scpeters/merge_2_3 branch November 11, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants