-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macros for generating pybind11 bindings #400
Open
Bi0T1N
wants to merge
4
commits into
gazebosim:main
Choose a base branch
from
Bi0T1N:pybind_macros
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bi0T1N <[email protected]>
azeey
approved these changes
Jan 2, 2024
azeey
reviewed
Jun 26, 2024
scpeters
reviewed
Jun 26, 2024
To focus our efforts on the Ionic release, I'll go ahead and remove the |
This reverts commit 7291d25.
Signed-off-by: Bi0T1N <[email protected]>
@j-rivero to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #215
Summary
This adds CMake macros to remove code duplication for creating pybind11 bindings.
The only problem that occurs is that it destroys the used structure in
CMakeLists.txt
(e.g. for gz-math):The other two macros are fine:
src/CMakeLists.txt
:Test it
/ws/install
mkdir build && cd build && cmake .. -DCMAKE_INSTALL_PREFIX=/ws/install/
make -j && make install
source /ws/install/setup.bash
, changeCMakeLists.txt
to usegz-cmake4
and the new macrosmkdir build && cd build && cmake .. && make -j
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸