Install the profiler in a version-safe manner #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the script to be side-by-side installable. Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 76.40% 76.40%
=======================================
Files 71 71
Lines 10080 10080
=======================================
Hits 7702 7702
Misses 2378 2378 Continue to review full report at Codecov.
|
Signed-off-by: Michael Carroll <[email protected]>
scpeters
reviewed
Feb 19, 2021
scpeters
approved these changes
Feb 20, 2021
Signed-off-by: Louise Poubel <[email protected]>
chapulina
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Report
Fixes issue #167
Fixes issue #82
Summary
This makes the profiler script get installed in a versioned subdirectory, which will enable side-by-side installs.
In this case, it follows along with our CLI executable strategy and installs to
install/lib/ignition/ignition-common4/ign_remotery_visThis additionally makes the profiler script relocatable by removing absolute paths from the CMake configuration process.
Checklist
Added testsUpdated migration guide (as needed)codecheckpassed (Seecontributing)
test coverage)
another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge