Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎈 3.11.0 #178

Merged
merged 1 commit into from
Mar 8, 2021
Merged

🎈 3.11.0 #178

merged 1 commit into from
Mar 8, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Mar 6, 2021

🎈 Release

Preparation for 3.11.0 release.

Comparison to 3.10.1: ignition-common3_3.10.1...ign-common3

Needed by:

Checklist

  • Asked team if this is a good time for a release (CC @mjcarroll )
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #178 (9b142df) into ign-common3 (944691e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common3     #178   +/-   ##
============================================
  Coverage        75.39%   75.39%           
============================================
  Files               72       72           
  Lines            10249    10249           
============================================
  Hits              7727     7727           
  Misses            2522     2522           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944691e...7a220fd. Read the comment docs.

@chapulina chapulina merged commit 38c0d0c into ign-common3 Mar 8, 2021
@chapulina chapulina deleted the chapulina/3.11.0 branch March 8, 2021 18:42
@peci1
Copy link
Contributor

peci1 commented Mar 8, 2021

Oh no, @chapulina, you broke our detectors!

3.10.1:

Snímek z 2021-03-09 00-53-04

3.11.0:

Snímek z 2021-03-09 00-53-57

As mentioned in #151 (comment) , #151 should be reverted and it should come with a better solution.

@peci1
Copy link
Contributor

peci1 commented Mar 8, 2021

And the links for 3.11.0 PRs in changelog are wrong (they refer to .../pulls/151 while it should be .../pull/151).

@chapulina
Copy link
Contributor Author

Reverting #151: #182

@chapulina
Copy link
Contributor Author

This release is also broken on arm64 and armhf because of #125: #180

chapulina added a commit that referenced this pull request Mar 19, 2021
* 🎈 3.11.0 (#178)

Signed-off-by: Louise Poubel <[email protected]>

* Relax expectation so encoder test passes on ARM (#183)

Signed-off-by: Louise Poubel <[email protected]>

* Revert "Associate library materials effect with meshes (#151)" (#182)

This reverts commit 89b1157.

Signed-off-by: Louise Poubel <[email protected]>

* 🎈 3.11.1 (#184)

Signed-off-by: Louise Poubel <[email protected]>

* Master branch updates (#179)

Part of gazebo-tooling/release-tools#416

Signed-off-by: Louise Poubel <[email protected]>

* Remove use of _SOURCE and _BINARY dirs in tests (#158)

Test cleanup:

Merges test/util.hh and test_config.h into a single file (fixes include path issues)
Adds fixtures for retrieving test data from test/data folder
Moves testing utilities into ignition::common::testing

Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Jose Luis Rivero <[email protected]>

Co-authored-by: Michael Carroll <[email protected]>
Co-authored-by: Jose Luis Rivero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants