Fix av_* API usage for deprecations #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-common3 #220 +/- ##
===============================================
- Coverage 76.56% 76.50% -0.06%
===============================================
Files 73 73
Lines 10357 10361 +4
===============================================
- Hits 7930 7927 -3
- Misses 2427 2434 +7
Continue to review full report at Codecov.
|
|
did you want to cherry-pick d6b7844? |
Ah! Didn't even see that. |
av_packet_alloc is already calling the equivalent of av_init_packet so we don't need to call it here. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
fix_av_deprecations
branch
from
cfc90d2 to
875037f
Compare
Signed-off-by: Michael Carroll <[email protected]>
chapulina
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #203
Summary
After this macOS and other platforms with newer ffmpeg/libav version (Fedora 34) should build without deprecation warnings.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge