Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test updates for common::testing module. #315

Merged
merged 12 commits into from
May 5, 2022
Merged

Test updates for common::testing module. #315

merged 12 commits into from
May 5, 2022

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Feb 23, 2022 •
edited by chapulina
Loading

Update ignition-common to make use of ign-common::testing

@mjcarroll mjcarroll mentioned this pull request Feb 23, 2022
Merged
@codecov
Copy link

codecov bot commented Feb 23, 2022 •
edited
Loading

Codecov Report

Merging #315 (be365b5) into main (3aadb66) will decrease coverage by 91.66%.
The diff coverage is n/a.

❗ Current head be365b5 differs from pull request most recent head 1e5d8c5. Consider uploading reports for the commit 1e5d8c5 to get more accurate results

@@            Coverage Diff            @@
##             main   #315       +/-   ##
=========================================
- Coverage   91.66%      0   -91.67%     
=========================================
  Files           1      0        -1     
  Lines          48      0       -48     
=========================================
- Hits           44      0       -44     
+ Misses          4      0        -4
Impacted Files Coverage Δ
test_config.h

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aadb66...1e5d8c5. Read the comment docs.

@chapulina chapulina added 🌱 garden Ignition Garden tests Broken or missing tests / testing infra labels Mar 3, 2022
@mjcarroll mjcarroll force-pushed the use_common_testing branch 2 times, most recently from b44c85c to d50255a Compare March 15, 2022 18:47
@mjcarroll mjcarroll self-assigned this Apr 5, 2022
Base automatically changed from add_common_testing to main April 11, 2022 12:32
@mjcarroll
Test updates
b52d96f 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Replace slashes in TEST_SUITE names for consistency
9824f9a 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll force-pushed the use_common_testing branch from d50255a to 9824f9a Compare April 11, 2022 13:42
@mjcarroll mjcarroll requested a review from nkoenig April 11, 2022 13:42
nkoenig
nkoenig approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@nkoenig nkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

src/Timer_TEST.cc Outdated Show resolved Hide resolved
@mjcarroll mjcarroll merged commit b87a28e into main May 5, 2022
@mjcarroll mjcarroll deleted the use_common_testing branch May 5, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoenig nkoenig nkoenig approved these changes

Assignees

@mjcarroll mjcarroll

Labels
🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjcarroll @nkoenig @chapulina