Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/CMakeLists.txt: fix find version variable #339

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Related to gazebo-tooling/release-tools#700

Summary

Use ignition-common5_VERSION_MAJOR to aid search/replace scripts.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Use ignition-common5_VERSION_MAJOR to aid search/replace
scripts.

Signed-off-by: Steve Peters <[email protected]>
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #339 (00f774b) into main (96df813) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   77.13%   77.13%           
=======================================
  Files          84       84           
  Lines       10661    10661           
=======================================
  Hits         8223     8223           
  Misses       2438     2438           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96df813...00f774b. Read the comment docs.

@mjcarroll mjcarroll enabled auto-merge (squash) April 12, 2022 01:34
@mjcarroll mjcarroll merged commit 181e6ee into main Apr 12, 2022
@mjcarroll mjcarroll deleted the scpeters/fix_example_find_version branch April 12, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants