Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Environment Variable Migration : gz-common #365

Merged
merged 3 commits into from
Jun 8, 2022
Merged

ign -> gz Environment Variable Migration : gz-common #365

merged 3 commits into from
Jun 8, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from mjcarroll as a code owner June 4, 2022 00:10
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 4, 2022
@methylDragon methylDragon mentioned this pull request Jun 4, 2022
Closed
49 tasks
@codecov
Copy link

codecov bot commented Jun 4, 2022 •
edited
Loading

Codecov Report

Merging #365 (386e35a) into main (c021582) will increase coverage by 77.88%.
The diff coverage is 48.14%.

❗ Current head 386e35a differs from pull request most recent head 26f7f5b. Consider uploading reports for the commit 26f7f5b to get more accurate results

@@            Coverage Diff            @@
##           main     #365       +/-   ##
=========================================
+ Coverage      0   77.88%   +77.88%     
=========================================
  Files         0       84       +84     
  Lines         0    10728    +10728     
=========================================
+ Hits          0     8356     +8356     
- Misses        0     2372     +2372
Impacted Files Coverage Δ
src/SystemPaths.cc 79.84% <38.88%> (ø)
av/src/VideoEncoder.cc 75.47% <66.66%> (ø)
graphics/include/gz/common/MeshLoader.hh 100.00% <0.00%> (ø)
graphics/src/Mesh.cc 100.00% <0.00%> (ø)
graphics/src/MeshExporter.cc 100.00% <0.00%> (ø)
testing/src/BazelTestPaths.cc 0.00% <0.00%> (ø)
graphics/src/SubMesh.cc 91.08% <0.00%> (ø)
src/Timer.cc 100.00% <0.00%> (ø)
include/ignition/common/PluginPtr.hh 100.00% <0.00%> (ø)
...tial/include/gz/common/geospatial/HeightmapData.hh 33.33% <0.00%> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c021582...26f7f5b. Read the comment docs.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 6, 2022
chapulina
chapulina suggested changes Jun 7, 2022
View reviewed changes
src/SystemPaths.cc Outdated Show resolved Hide resolved
src/SystemPaths.cc Outdated Show resolved Hide resolved
src/SystemPaths.cc Outdated Show resolved Hide resolved
src/SystemPaths.cc Outdated Show resolved Hide resolved
@methylDragon
Update tick-tocking logic
21c47bb 
Signed-off-by: methylDragon <[email protected]>
chapulina
chapulina suggested changes Jun 7, 2022
View reviewed changes
src/SystemPaths.cc Outdated Show resolved Hide resolved
src/SystemPaths.cc Outdated Show resolved Hide resolved
@methylDragon
Fix SystemPaths.cc
26f7f5b 
Signed-off-by: methylDragon <[email protected]>
@chapulina chapulina merged commit 6b749fe into main Jun 8, 2022
@chapulina chapulina deleted the env_var_migration branch June 8, 2022 04:07
luca-della-vedova pushed a commit that referenced this pull request Jul 27, 2022
@methylDragon @luca-della-vedova
ign -> gz Environment Variable Migration (#365)
abac67e 
Signed-off-by: methylDragon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina