Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove configure.bat, export CXX_STANDARD #387

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Remove configure.bat, export CXX_STANDARD #387

merged 3 commits into from
Jul 6, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 3, 2022 •
edited
Loading

🦟 Bug fix

Testing a fix for #386 using the matching branch name of gazebosim/gz-cmake#271

Summary

I needed to make a change in order to test the fix for #386 and it's safe to remove configure.bat on any branches not used by gazebo11's CI, so I'm doing so here.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 3, 2022
This was referenced Jul 3, 2022
Closed
Merged
@scpeters
Copy link
Member Author

scpeters commented Jul 3, 2022

Success! https://build.osrfoundation.org/job/ign_common-pr-win/487/testReport/(root)/VideoEncoderTest/

@scpeters scpeters marked this pull request as ready for review July 3, 2022 07:24
@scpeters scpeters requested a review from mjcarroll as a code owner July 3, 2022 07:24
@chapulina
Copy link
Contributor

@osrf-jenkins run tests please now that gazebosim/gz-cmake#271 has been merged

@scpeters
Copy link
Member Author

scpeters commented Jul 5, 2022

the windows build failed due to the matching gazebodistro branch name, so I deleted that branch and am retrying the build

@scpeters
Copy link
Member Author

scpeters commented Jul 5, 2022

some examples are failing to compile in the Focal workflow; I'll fix them shortly

@scpeters
Copy link
Member Author

scpeters commented Jul 5, 2022

I believe the examples were failing to compile because the core library doesn't export a CXX_STANDARD; I've fixed this in 0ca0906

@codecov
Copy link

codecov bot commented Jul 5, 2022 •
edited
Loading

Codecov Report

Merging #387 (c58b392) into main (4416bee) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   77.83%   77.83%           
=======================================
  Files          85       85           
  Lines       10771    10771           
=======================================
  Hits         8384     8384           
  Misses       2387     2387
Impacted Files Coverage Δ
geospatial/src/Dem.cc 91.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4416bee...c58b392. Read the comment docs.

@scpeters scpeters changed the title Remove configure.bat and test fix for finding av Remove configure.bat, export CXX_STANDARD Jul 5, 2022
@scpeters
Copy link
Member Author

scpeters commented Jul 5, 2022

compiler warnings will be fixed in #377

@scpeters
Fix deprecation warnings
c58b392 
Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member Author

scpeters commented Jul 6, 2022

compiler warnings will be fixed in #377

warnings fixed in c58b392

@scpeters
Copy link
Member Author

scpeters commented Jul 6, 2022

compiler warnings will be fixed in #377

warnings fixed in c58b392

rebuilding math7 nightly debs...

@scpeters scpeters merged commit a714900 into main Jul 6, 2022
@scpeters scpeters deleted the ci_matching_branch/fix_manual_search branch July 6, 2022 05:19
luca-della-vedova pushed a commit that referenced this pull request Jul 27, 2022
@scpeters @luca-della-vedova
Remove configure.bat, export CXX_STANDARD (#387)
ebe514c 
* Remove configure.bat and test fix for finding av
* Set CXX_STANDARD for core library
* Fix deprecation warnings

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @chapulina