Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing cstdint header in latest gcc build #513

Merged
merged 1 commit into from
May 22, 2023

Conversation

zaidhaan
Copy link
Contributor

🦟 Bug fix

#512 fix done against ign-common3. (summary: missing <cstdint> header thrown on GCC 13.1.1)

cc @marcoag

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@zaidhaan zaidhaan requested a review from marcoag as a code owner May 22, 2023 09:44
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 22, 2023
@marcoag
Copy link
Member

marcoag commented May 22, 2023

Just confirmed the bug and fix over a fresh arch install. Thanks for the fix!

Copy link
Member

@marcoag marcoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing DCO, PTAL.

@zaidhaan zaidhaan force-pushed the fix-add-missing-cstdint branch from 00cabde to ad31a18 Compare May 22, 2023 10:24
@zaidhaan
Copy link
Contributor Author

Missing DCO, PTAL.

Done, thanks for the heads up.

@zaidhaan zaidhaan force-pushed the fix-add-missing-cstdint branch from ad31a18 to 65b028a Compare May 22, 2023 10:27
@zaidhaan zaidhaan requested a review from marcoag May 22, 2023 12:19
@mjcarroll
Copy link
Contributor

CI failures here were infra issues. LGTM.

@mjcarroll mjcarroll merged commit ec86532 into gazebosim:ign-common3 May 22, 2023
@zaidhaan zaidhaan deleted the fix-add-missing-cstdint branch May 22, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants