Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cstdint to build with GCC 13 #517

Merged

Conversation

aedalzotto
Copy link
Contributor

@aedalzotto aedalzotto commented May 31, 2023

🦟 Bug fix

Summary

Building with GCC 13 will fail due to uint32_t in:

public: virtual void BeginSample(const char *_name, uint32_t *_hash) = 0;

This PR can (and should) be included in newer versions too.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Angelo Elias Dal Zotto <[email protected]>
@aedalzotto aedalzotto requested a review from marcoag as a code owner May 31, 2023 11:56
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ign-common3@ec86532). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4974535 differs from pull request most recent head aaf780e. Consider uploading reports for the commit aaf780e to get more accurate results

@@              Coverage Diff               @@
##             ign-common3     #517   +/-   ##
==============================================
  Coverage               ?   82.67%           
==============================================
  Files                  ?       72           
  Lines                  ?     9246           
  Branches               ?        0           
==============================================
  Hits                   ?     7644           
  Misses                 ?     1602           
  Partials               ?        0           

@mjcarroll mjcarroll merged commit c9c2003 into gazebosim:ign-common3 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants