Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fuel backend] Some headers should or shouldn't be installed #29

Closed
osrf-migration opened this issue Jul 14, 2017 · 2 comments · Fixed by #109
Closed

[Fuel backend] Some headers should or shouldn't be installed #29

osrf-migration opened this issue Jul 14, 2017 · 2 comments · Fixed by #109
Assignees
@ahcorde
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@osrf-migration
Copy link

Original report (archived issue) by Shane Loretz (Bitbucket: Shane Loretz, GitHub: sloretz).

LocalCache.hh doesn't need to be installed, but it is. Helpers needs to be installed, but it isn't.
@osrf-migration osrf-migration added major bug Something isn't working labels Apr 15, 2020
@chapulina chapulina removed the major label May 26, 2020
@chapulina
Copy link
Contributor

Helpers.hh is already being installed, but LocalCache.hh could be removed here:

https://github.com/ignitionrobotics/ign-fuel-tools/blob/1676ab9986ee30f025a101a4d421c8f5cfde74f4/include/ignition/fuel_tools/CMakeLists.txt#L1-L4

Or, even better, it could be moved to the src folder.

@chapulina chapulina added the good first issue Good for newcomers label May 26, 2020
@chapulina chapulina mentioned this issue May 26, 2020
Closed
@ahcorde ahcorde mentioned this issue Aug 24, 2020
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Aug 24, 2020

PR is open #109

@ahcorde ahcorde self-assigned this Aug 27, 2020
@ahcorde ahcorde linked a pull request Aug 27, 2020 that will close this issue
Hide Private headers and LocalCache.hh #109
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahcorde ahcorde

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide Private headers and LocalCache.hh gazebosim/gz-fuel-tools
3 participants
@ahcorde @chapulina @osrf-migration