Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private headers shouldn't be installed #44

Closed
osrf-migration opened this issue Mar 15, 2018 · 5 comments · Fixed by #109
Closed

Private headers shouldn't be installed #44

osrf-migration opened this issue Mar 15, 2018 · 5 comments · Fixed by #109
Assignees
@ahcorde
Labels
bug Something isn't working

Comments

@osrf-migration
Copy link

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

We try to keep private headers in the src folder instead of include so they don't get installed.
@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).

Would moving them in a minor release affect ABI / API? I would think so, since right now users could be including them...?

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

Technically yes, but users shouldn't be using them, so we can take them out.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

It will affect API but not ABI

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 15, 2020
@chapulina chapulina removed the major label May 26, 2020
@chapulina
Copy link
Contributor

Related to #29

@ahcorde ahcorde mentioned this issue Aug 24, 2020
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Aug 24, 2020

PR is open #109

@ahcorde ahcorde self-assigned this Aug 27, 2020
@ahcorde ahcorde linked a pull request Aug 27, 2020 that will close this issue
Hide Private headers and LocalCache.hh #109
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahcorde ahcorde

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide Private headers and LocalCache.hh gazebosim/gz-fuel-tools
3 participants
@ahcorde @chapulina @osrf-migration