Use semantic version and prevent crash if version is missing #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting a crash while downloading a model with a malformed config:
The problem is that the
<sdf>
element of that model doesn't have aversion
attribute.To prevent a crash, I'm assuming a version 0.0.1.
Which begs the question, is that version meant to be semantic? I don't think that has been specified anywhere. But considering that most models have a version in the format
X.X
, I think semantic versioning would make more sense than doubles. That is,1.12
is larger than1.2
. So I also updated the logic to use Ignition Math'sSemanticVersion
class. This adds an explicit dependency onign-math
, but that should be ok, because that was already an indirect dependency throughign-common
andign-msgs
.