-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More checks when manipulating file system in tests #227
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools4 #227 +/- ##
================================================
Coverage 77.90% 77.90%
================================================
Files 19 19
Lines 2715 2715
================================================
Hits 2115 2115
Misses 600 600 Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
* Improve and fix ResultType tests (#225) Signed-off-by: Louise Poubel <[email protected]> * Move test cache to build folder (#222) Signed-off-by: Louise Poubel <[email protected]> * More checks when manipulating file system in tests (#227) Signed-off-by: Louise Poubel <[email protected]>
🎉 New feature
Summary
These checks are useful when debugging test failures. At a minimum, they allow us to rule-out these lines are reasons for the failure.
The changes consist in expecting true for these calls:
createDirectories
copyFile
This is motivated by debugging #224
Test it
CI should pass for all platforms
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸