Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 7 -> main #240

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Merge 7 -> main #240

merged 3 commits into from
Mar 28, 2022

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port ign-fuel-tools7 to main

Branch comparison: main...ign-fuel-tools7

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

scpeters and others added 2 commits March 7, 2022 13:05
Signed-off-by: Steve Peters <[email protected]>
* Added sdfFromPath helper function to get SDF file from a Fuel model or world

Signed-off-by: Nate Koenig <[email protected]>

* Remove whitesapce

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
@scpeters scpeters requested a review from nkoenig as a code owner March 18, 2022 21:09
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 18, 2022
@scpeters
Copy link
Member Author

Jammy CI is blocked on ign-msgs9 debs

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #240 (03a13be) into main (e4caf26) will increase coverage by 0.04%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   75.49%   75.54%   +0.04%     
==========================================
  Files          20       20              
  Lines        2820     2850      +30     
==========================================
+ Hits         2129     2153      +24     
- Misses        691      697       +6     
Impacted Files Coverage Δ
src/Interface.cc 83.92% <80.00%> (-4.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4caf26...03a13be. Read the comment docs.

@scpeters scpeters mentioned this pull request Mar 18, 2022
@scpeters
Copy link
Member Author

closed in favor of #241 while we wait for jammy debs of ign-msgs9

@scpeters scpeters closed this Mar 18, 2022
@scpeters scpeters reopened this Mar 26, 2022
@chapulina chapulina merged commit ff89488 into main Mar 28, 2022
@chapulina chapulina deleted the merge7main branch March 28, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants