Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test_config to align with other packages #246

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Summary

This moves the generated test_config.h to not be in test, which brings it in line with the rest of the ignition packages.

It also rearranges a bit of the gtest cmake logic so that the targets/includes are more explicit.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll requested a review from nkoenig as a code owner April 5, 2022 13:41
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 5, 2022
@mjcarroll mjcarroll self-assigned this Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #246 (20d1df6) into main (bd50422) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

❗ Current head 20d1df6 differs from pull request most recent head 2cdad7f. Consider uploading reports for the commit 2cdad7f to get more accurate results

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   75.57%   75.56%   -0.02%     
==========================================
  Files          20       20              
  Lines        2850     2848       -2     
==========================================
- Hits         2154     2152       -2     
  Misses        696      696              
Impacted Files Coverage Δ
include/ignition/fuel_tools/Result.hh 100.00% <ø> (ø)
src/FuelClient.cc 67.77% <0.00%> (ø)
src/RestClient.cc 67.42% <100.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd50422...2cdad7f. Read the comment docs.

@mjcarroll mjcarroll merged commit 12e683e into main Apr 5, 2022
@mjcarroll mjcarroll deleted the move_test_config branch April 5, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants