Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up a few Windows warnings #308

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Related to: gazebosim/gz-sim#1771

Summary

Remove some Windows warnings.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from nkoenig as a code owner October 31, 2022 18:52
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 31, 2022
@mjcarroll mjcarroll mentioned this pull request Oct 31, 2022
8 tasks
Signed-off-by: Michael Carroll <[email protected]>
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #308 (02b0d83) into gz-fuel-tools8 (c1acd16) will increase coverage by 0.75%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           gz-fuel-tools8     #308      +/-   ##
==================================================
+ Coverage           73.77%   74.52%   +0.75%     
==================================================
  Files                  20       20              
  Lines                2871     2866       -5     
==================================================
+ Hits                 2118     2136      +18     
+ Misses                753      730      -23     
Impacted Files Coverage Δ
src/ClientConfig.cc 81.70% <ø> (-0.39%) ⬇️
src/FuelClient.cc 67.33% <ø> (ø)
src/Interface.cc 83.92% <ø> (-1.79%) ⬇️
src/gz.cc 48.88% <ø> (+7.44%) ⬆️
src/RestClient.cc 67.42% <0.00%> (-4.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit bae3afe into gz-fuel-tools8 Oct 31, 2022
@mjcarroll mjcarroll deleted the mjcarroll/build_green branch October 31, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants